Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make page down/page up work in file picker #1467

Closed
hahanein opened this issue Jan 9, 2022 · 2 comments · Fixed by #1612
Closed

Make page down/page up work in file picker #1467

hahanein opened this issue Jan 9, 2022 · 2 comments · Fixed by #1612
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors

Comments

@hahanein
Copy link
Contributor

hahanein commented Jan 9, 2022

Currently when opening the file picker, page up/page down/ctrl+d/ctrl+u all move the cursor to the first line on the first page.

It'd be nice if those really moved you page by page in the appropriate direction.
@hahanein hahanein added the C-enhancement Category: Improvements label Jan 9, 2022
@pickfire pickfire added E-easy Call for participation: Experience needed to fix: Easy / not much A-helix-term Area: Helix term improvements labels Jan 9, 2022
@archseer archseer added the E-good-first-issue Call for participation: Issues suitable for new contributors label Jan 9, 2022
@twe4ked twe4ked mentioned this issue Jan 11, 2022
Closed
hahanein added a commit to hahanein/helix that referenced this issue Jan 19, 2022
@hahanein
Make page down/page up work in file picker helix-editor#1467
0efb1e1
@schoenenberg
Copy link
Contributor

It looks like this is already done. Only PR missing @hahanein?

@hahanein
Copy link
Contributor Author

@schoenenberg This version is pretty much a hack.

The proper way'd be using callback_fn as I understand. But there seems to be quite a bit of work to be done to get this to work that I haven't yet managed.

@Aloso Aloso mentioned this issue Feb 1, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
A-helix-term Area: Helix term improvements C-enhancement Category: Improvements E-easy Call for participation: Experience needed to fix: Easy / not much E-good-first-issue Call for participation: Issues suitable for new contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add PageUp, PageDown, Ctrl-u, Ctrl-d, Home, End keyboard shortcuts to file picker Aloso/helix
4 participants
@archseer @pickfire @schoenenberg @hahanein