adds build commit hash to --version output #1032
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the build commit hash to the `--version` output. This helps while helix is built regularly from git sources on the master branch. This commit works by using a Cargo build script. It shells out to `git rev-parse HEAD` at compile time. It then sets a Cargo environment variable with the version plus commit hash. Where the version is displayed in the `main()` function, at compile time the Cargo env var is read and the contents compiled into the binary as a static string. The output looks like: ```console $ hx --vesrion helix 0.5.0 (490919d) ```
|
There's already #957 open too |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the build commit hash to the
--versionoutput. Thishelps while helix is built regularly from git sources on the master
branch.
This commit works by using a Cargo build script. It shells out to
git rev-parse HEADat compile time. It then sets a Cargo environmentvariable with the version plus commit hash. Where the version is
displayed in the
main()function, at compile time the Cargo env var isread and the contents compiled into the binary as a static string.
The output looks like:
I find this super useful while building helix from source commonly and knowing where in the history my current binary is at.
If there is no interest in this feature, please feel free to close 😄