Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allows open file at +<line>:<column> from the command line #1129

Conversation

Rational-Curiosity
Copy link
Contributor

New command line parameter

hx +10:7 file.ext
hx +10 file.ext

@Rational-Curiosity Rational-Curiosity changed the title Allows open file at line and column with +<line>:<column> command line Allows open file at line and column with +<line>:<column> Nov 18, 2021
@s1ck
Copy link
Contributor

s1ck commented Nov 18, 2021

That's cool. I just opened #1128 :)

@Rational-Curiosity Rational-Curiosity changed the title Allows open file at line and column with +<line>:<column> Allows open file at +<line>:<column> from the command line Nov 18, 2021
@Rational-Curiosity
Copy link
Contributor Author

Rational-Curiosity commented Nov 18, 2021

That's cool. I just opened #1128 :)

Thanks, improving helix all together...

@Rational-Curiosity Rational-Curiosity changed the title Allows open file at +<line>:<column> from the command line Allows open file at +<line>:<column> from the command line Nov 18, 2021
@sudormrfbin
Copy link
Member

There's already #445 open which implements this in the format of hx file.txt:line:col.

@Rational-Curiosity
Copy link
Contributor Author

There's already #445 open which implements this in the format of hx file.txt:line:col.

The +line is widely used, and many linux aplications assumes it. I would support both options but implementations are very different...

@pickfire
Copy link
Contributor

pickfire commented Nov 20, 2021

The +line is widely used, and many linux aplications assumes it. I would support both options but implementations are very different...

It's good to see this too, but I think it seemed limited to a single file.

I would like to see the other pull request I created merged first. Also, this pull request seemed to put the logic in a weird part, it should probably be in editor.open.

@Rational-Curiosity
Copy link
Contributor Author

The +line is widely used, and many linux aplications assumes it. I would support both options but implementations are very different...

It's good to see this too, but I think it seemed limited to a single file.

I would like to see the other pull request I created merged first. Also, this pull request seemed to put the logic in a weird part, it should probably be in editor.open.

Of course, I'll pick up this issue after you finish. About the logic, I don't care where to put the code. The implementation has very few lines of code indicating how well it fits the solution to the problem.

@the-mikedavis the-mikedavis added the S-waiting-on-review Status: Awaiting review from a maintainer. label May 18, 2022
@archseer
Copy link
Member

archseer commented Jun 5, 2022

With #445 merged, feel free to reopen if you revisit this PR in the future

@archseer archseer closed this Jun 5, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-review Status: Awaiting review from a maintainer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants