Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Selecting around " while cursor is on " will no longer error #12494

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

nik-rev
Copy link
Contributor

@nik-rev nik-rev commented Jan 11, 2025

Previously, if you had a file like this:

"ui.text" "example"

Having cursor on the 2nd " will give an error: Cursor on ambiguous pair

With this PR, it won't error anymore and it will highlight the entire "ui.text" correctly. This fall-back works for files with tree-sitter support. For files without, it will just have the old behaviour

Closes #12478

@nik-rev nik-rev changed the title feat: Selecting around " while cursor is on " will no longer error fix: Selecting around " while cursor is on " will no longer error Jan 11, 2025
@robinmoussu
Copy link

It fixes #12478 but not #12454. If your cursor is on the right quote (either simple or double), mim/mam will still select inner/outer block one level above.

@nik-rev
Copy link
Contributor Author

nik-rev commented Jan 11, 2025

It fixes #12478 but not #12454. If your cursor is on the right quote (either simple or double), mim/mam will still select inner/outer block one level above.

Thanks, I'll remove that mention now!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mi" does not work when the cursor is on either quote (likewise for mi', ma", ma')
2 participants