Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improve rust macro highlighting #1295

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Improve rust macro highlighting #1295

merged 1 commit into from
Dec 20, 2021

Conversation

sudormrfbin
Copy link
Member

@sudormrfbin sudormrfbin commented Dec 18, 2021 •
edited
Loading

  • Highlight fragment specifiers (expr, tt, in macro definitions) with @type.
  • Highlight attributes as macros.
Before After
before-rust after-rust

Note that it looks drastic for onedark only from what I tested since it doesn't define some punctuation highlights.

@sudormrfbin
Improve rust syntax highlighting
f0f79c6 
- Highlight fragment specifiers (expr, tt, in macro
  definitions) with @type.
- Highlight attributes as macros
dead10ck
dead10ck approved these changes Dec 19, 2021
View reviewed changes
Copy link
Member

@dead10ck dead10ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sudormrfbin sudormrfbin changed the title Improve rust highlighting Improve rust macro highlighting Dec 19, 2021
archseer
archseer approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@archseer archseer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'll need to get used to this because the # is now colored as punctuation

@archseer archseer merged commit f1c6343 into helix-editor:master Dec 20, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@dead10ck dead10ck dead10ck approved these changes

@archseer archseer archseer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sudormrfbin @dead10ck @archseer