Use a fuzzy matcher for commands #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead10ck
approved these changes
Dec 28, 2021
archseer
reviewed
Dec 28, 2021
helix-term/src/commands.rs
Outdated
| @@ -3044,6 +3045,9 @@ pub mod cmd { | |||
| }); | |||
| } | |||
|
|
|||
| static FUZZY_MATCHER: Lazy<fuzzy_matcher::skim::SkimMatcherV2> = | |||
There was a problem hiding this comment.
minor: Since this is only used inside fn command_mode I'd move the definition inside the fn body, that way it's scoped to the command.
|
I think it's okay to drop the old behavior here 👍🏻 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For me this is a nice quality of life improvement that helps with discoverability of commands. Open to other points of view though 😄