Upgrade and reenable tree-sitter-haskell

[414owen]

I've made changes to tree-sitter-haskell that remove the need for c++14. It now happily compiles with c++11.
I think this is ubiquitous enough to reenable it by default?

[kirawi]

Looks like you'll have to enable C++11 in build_library().

[archseer]

helix/helix-syntax/build.rs

Line 76 in 0dab6c8

if cfg!(windows) {

Should look something like 212f6bc

[kirawi]

I see you also have a PR to drop the requirement to C++03: 414owen/tree-sitter-haskell#1
I'm not sure, but I think you wouldn't have to change anything else in Helix if that were to get merged,

[414owen]

I see you also have a PR to drop the requirement to C++03: 414owen/tree-sitter-haskell#1 I'm not sure, but I think you wouldn't have to change anything else in Helix if that were to get merged,

I'll see if I can get that touched up.

[414owen]

Okay I've changed tree-sitter-haskell to only rely on a c99 compiler. Should be portable enough :)

[archseer]

This is great!

You will probably also want to pull in the locals.scm query and update the highlights.scm one: https://github.com/tree-sitter/tree-sitter-haskell/tree/master/queries

The current file predates the tree-sitter-haskell rewrite.

[414owen]

@archseer Looks like those files were updated 19 days ago and 7 months ago, whereas the haskell-tree-sitter grammar's last major features were added in March 2021. I think this should be okay?

It certainly seems to be highlighting correctly when I test it.

If not, what's the process here? Cross-reference helix's known token categories with what haskell-tree-sitter produces?

[kirawi]

You should be able to copy the ones in the repo, and then what you'll have to do is change the captures (e.g. @number) to the ones used by Helix (e.g. @constant.numeric.integer).

[414owen]

Okay everything in highlights.scm is now understood by helix.

[414owen]

The worst mapping (preserved from before) is:

[
  "forall"
  "∀"
] @keyword.control.repeat

In haskell these are quantifiers, and have nothing to do with loops. I don't suppose helix wants to add a keyword.quantifier scope?

[archseer]

Do you want to style these separately? If not, it's enough to use @keyword

[414owen]

Do you want to style these separately? If not, it's enough to use @keyword

No that's okay. I've changed them to keyword.

[414owen]

One last update to highlights.scm to add infix operators (recently added to tree-sitter-haskell).

Think we're ready to merge?

[archseer]

Thanks for working on this! 🎉