Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add gruvbox-light theme #1509

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Conversation

crodjer
Copy link
Contributor

@crodjer crodjer commented Jan 14, 2022

Similar to gruvbox, add the light version as well.

Similar to `gruvbox`, add the light version as well.
Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I think you might also want to add it to the wiki. https://github.com/helix-editor/helix/wiki/Themes

@pickfire pickfire merged commit 97e6f2a into helix-editor:master Jan 14, 2022
@archseer
Copy link
Member

The theme is missing markup. scopes, can you add those as well?

@crodjer
Copy link
Contributor Author

crodjer commented Jan 14, 2022

The theme is missing markup. scopes, can you add those as well?

@archseer Not aware of markup.. I borrowed from the existing gruvbox (dark) theme, which didn't have it.

@archseer
Copy link
Member

They were a recent addition so they are missing from the dark theme too

helix/theme.toml

Lines 31 to 36 in 97e6f2a

"markup.heading" = "lilac"
"markup.bold" = { modifiers = ["bold"] }
"markup.italic" = { modifiers = ["italic"] }
"markup.link.url" = { fg = "silver", modifiers = ["underlined"] }
"markup.link.text" = "almond"
"markup.raw" = "almond"

It's used for styling markdown and will soon also be used for documentation popups

crodjer added a commit to crodjer/helix that referenced this pull request Jan 15, 2022
@crodjer
Copy link
Contributor Author

crodjer commented Jan 15, 2022

@archseer Thanks for the suggestion, crated a PR: #1518

@crodjer crodjer deleted the gruvbox-light branch January 15, 2022 11:40
archseer pushed a commit that referenced this pull request Jan 16, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants