Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix hover menu item text color in base16 themes #1668

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Fix hover menu item text color in base16 themes #1668

merged 2 commits into from
Feb 15, 2022

Conversation

david-crespo
Copy link
Contributor

Fixes #1665

Not 100% confident here but it seems like the right idea?

image

@archseer
Copy link
Member

Looks reasonable, but do the other two base16_ themes need the same fix?

@david-crespo
Copy link
Contributor Author

They did! I don't really like what's going on in base16_terminal but there doesn't seem to be a dark gray that's not black.

Screen Shot 2022-02-15 at 12 03 27 AM

Screen Shot 2022-02-15 at 12 08 41 AM

@david-crespo david-crespo changed the title Fix hover menu item text color in base16 dark theme Fix hover menu item text color in base16 themes Feb 15, 2022
@archseer
Copy link
Member

Thanks! For the _terminal version, you're supposed to set your terminal emulator's 16 colors to base 16 then this theme would look correctly. The other ones all use truecolor

@archseer archseer merged commit a629343 into helix-editor:master Feb 15, 2022
@david-crespo david-crespo deleted the fix-base16-dark branch February 15, 2022 05:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

base16_default_dark theme hover menu item text same color as background
2 participants
@david-crespo @archseer