Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update tree-sitter-git-commit with performance fix #1838

Merged

Conversation

the-mikedavis
Copy link
Member

@the-mikedavis the-mikedavis commented Mar 18, 2022

Any text following a scissors node is now contained in one message node. This is a huge speed boost for verbose commits which inject tree-sitter-git-diff after the scissors. The old behavior was that each line was its own injection, which is slow when there are thousands of injections.

cherry-picked out of #1728
closes #1836
see also the-mikedavis/tree-sitter-git-commit@d046669

changes:

- any text following a (scissors) is now contained in one (message)
    - this vastly improves performance on large verbose commits:
      no more slowness on huge commits
@archseer archseer merged commit cfd992b into helix-editor:master Mar 19, 2022
@the-mikedavis the-mikedavis deleted the md-update-tree-sitter-git-commit branch March 19, 2022 12:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slow performance when editing initial git commit message
2 participants