Update tree-sitters Erlang and HEEx #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Special HEEx templating tokens are highlighted as keywords similar
to EJS/ERB highlights. The braces are templating tokens too. For
example you can conveniently interpolate an attribute's value
like so:
<div class={unless @show, do: "hidden"}></div>
For consistency these should be highlighted like the other templating
tokens.
changes: * fixed highlights for callbacks and ifdef/ifndef attributes * all attributes are now highlighted as keywords for simplicity * fixed precedence between unused variable and macro highlights * the 'quoted_atom' rule has been consolidated into 'atom' which improves highlights in scenarios where the pattern matches an atom
the-mikedavis
force-pushed
the
md-beam-party-pack-2
branch
from
b2e8c91 to
10cded6
Compare
sudormrfbin
approved these changes
Apr 17, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HEEx has a small fix for the highlights:
{/}should be@keywords like the rest of the templating tokens.Erlang has a few fixes
?_assertEqual/2are highlighted as macros rather thancomment.unused(atom)which simplifies some highlight scenarios