Fix nix shell by hardcoding the flakecompat library #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it wasn't available in the lockfile, I just hardcoded it in the shell.nix file. This is a possible solution for helix-editor#2195
the-mikedavis
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
I think this is reasonable. The recommended way (from the readme) has you adding flake-compat as an input to the flake but IMO that's a bit weird because the flake doesn't need the compat - the non-flake shell does.
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it wasn't available in the lockfile, I just hardcoded it
in the shell.nix file.
This is a possible solution for
#2195