Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(helix-view): view debug output on windows #2294

Merged
merged 1 commit into from
May 11, 2022

Conversation

axdank
Copy link
Contributor

@axdank axdank commented Apr 26, 2022

Tmux is not available on windows, so it raises an error and closes the helix editor with a warning pointing to handlers/dap.

debug_panic

Therefore I decided to add a piece of code so that a new terminal can be opened, either with Windows Terminal or Conhost ( both running cmd.exe inside ).

In case of having windows terminal ( wt.exe ), it is executed in it.

In case of not having it, it is executed in ( conhost.exe ).

Example ( conhost.exe ):

image

image

Example ( wt.exe ):

image

@axdank axdank changed the title Run debug console in windows feat(helix-view): view debug output on windows Apr 27, 2022
@axdank
Copy link
Contributor Author

axdank commented Apr 30, 2022

@the-mikedavis Sorry, I wanted to check if this code can be applied. Previously I created a pull request (of the same thing) but I didn't realize that the code was formatted and generated unnecessary changes in git (+331, −311 ), so I closed it and recreated it correctly.

@the-mikedavis
Copy link
Member

This looks good to me but let's wait for a maintainer with more rust experience to review 👍

@archseer
Copy link
Member

archseer commented May 2, 2022

The idea is to have this configurable via an editor.terminal = { cmd = "foo", args = ["bar"] } type setting with some reasonable defaults similar to how the clipboard works. Would you be prepared to work on that in this PR? If not I can merge this as is for now and open a separate tracking issue

@axdank
Copy link
Contributor Author

axdank commented May 2, 2022

@archseer If there is a possibility to merge this momentarily, it would be the best, because my knowledge in rust is still very basic 😞.

@archseer archseer merged commit c80ac84 into helix-editor:master May 11, 2022
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 15, 2022
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 15, 2022
@axdank axdank deleted the windows_debug_process_fix branch July 21, 2022 14:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants