Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add tree-sitter ssh client config queries #2498

Merged

Conversation

midnightexigent
Copy link
Contributor

@midnightexigent midnightexigent commented May 18, 2022

@the-mikedavis
Copy link
Member

You can move the configuration in languages.toml over to this PR as well. The new language can be merged without #2455: it won't automatically highlight on ssh config files until that PR is merged but it would be possible to manually set the syntax :lang sshclientconfig in the meantime.

@midnightexigent midnightexigent force-pushed the sshclientconfig-syntax branch from b3a017a to a01e363 Compare May 18, 2022 18:18
@midnightexigent
Copy link
Contributor Author

Somehow forgot about that. Done

@the-mikedavis the-mikedavis self-requested a review May 18, 2022 18:23
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little nit and then this looks good 👍

languages.toml Outdated Show resolved Hide resolved
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
@the-mikedavis
Copy link
Member

The queries are a little verbose because the grammar has a lot of different nodes. I think it could be refactored to be a little cleaner - I might take a look at forking it at some point.

@the-mikedavis the-mikedavis merged commit 8493b5f into helix-editor:master May 18, 2022
@midnightexigent midnightexigent deleted the sshclientconfig-syntax branch May 18, 2022 21:31
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 15, 2022
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 15, 2022
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants