Elixir: inject Markdown into docs, remove h sigil HEEx injection #2619
+10
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Davis <mcarsondavis@gmail.com>
the-mikedavis
approved these changes
May 31, 2022
|
W.r.t. tests, I think it might be good in the long-run to have highlight tests in the CI and/or cargo testsuite. For now I think it would be a little heavy since we're adding new languages very often and tree-sitter queries are already a lot to learn if you've never seen tree-sitter before |
I see our Helix evangelism strikeforce is just as strong as the Rust one :D |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@the-mikedavis I figured I'd checkout Helix and see how it compares to Neovim. Consider me a convert 😆
This PR contains two changes:
hsigil from Elixir language injections. Phoenix Live View only supports the uppercaseHsigil for HEEx.Please let me know if there are any tests or documentation that need to be updated. Thanks!