-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
text-objects: add test capture & elixir queries #2807
text-objects: add test capture & elixir queries #2807
Conversation
cc1d4eb
to
abb865a
Compare
This is looking good :) I might push a commit or two with queries for more languages if that's alright |
Go for it! Which languages did you have in mind? |
I was thinking at least Rust but also Erlang for my sake 😄 For Rust, we can capture the function following the For a few of languages (Erlang EUnit tests and Gleam Gleeunit for example) we could have the captures be pretty much the same as |
@the-mikedavis What do you think about queries for languages that have a number of popular test frameworks, like JavaScript? This leads me to wonder if Helix should support some kind of opt-in queries for specific frameworks? Highlights and textobjects for the Phoenix router DSL would be handy to have available, but I don't think belongs in the core Elixir queries. |
Hmm I think we should aim to only support official language tooling in the core and leave framework-specific features to plugins (once implemented). Especially if two frameworks conflict, it's hard to be rigorous about which one should get support. For this feature in particular though I don't see any harm in supporting javascript testing frameworks for example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @connorlay, this is great!
See #2792