Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix backwards selection duplication widening bug #2945

Merged
merged 3 commits into from
Jul 4, 2022

Conversation

A-Walrus
Copy link
Contributor

@A-Walrus A-Walrus commented Jul 2, 2022

Fixes #2854

@sudormrfbin
Copy link
Member

This would benefit from integration tests, see https://github.com/helix-editor/helix/tree/master/helix-term/tests/test for examples of testing indent, auto pairs, etc.

@A-Walrus

This comment was marked as resolved.

Make tests line-ending agnostic

Use indoc to fix tests

Fix line-ending on test input
@A-Walrus A-Walrus force-pushed the backwards_selection branch from 1babb72 to 07db29a Compare July 3, 2022 17:35
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

The tests look great! Thanks for the fix

@archseer archseer merged commit 2ac1de3 into helix-editor:master Jul 4, 2022
@A-Walrus A-Walrus deleted the backwards_selection branch August 1, 2022 07:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backward Selection Duplication Widening Selection.
4 participants