keep jump/file history when using :split #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pickfire
reviewed
Jul 11, 2022
helix-term/src/commands.rs
Outdated
Comment on lines
4007
to
4008
| view.docs_access_history = docs_access_history; | ||
| view.last_modified_docs = last_modified_docs; |
There was a problem hiding this comment.
Why do we need to change these?
There was a problem hiding this comment.
alternate file uses this, "space a"
archseer
requested changes
Jul 12, 2022
helix-term/src/commands.rs
Outdated
Comment on lines
3995
to
4010
| let jumps = view.jumps.clone(); | ||
| let docs_access_history = view.docs_access_history.clone(); | ||
| let last_modified_docs = view.last_modified_docs; | ||
| let object_selections = view.object_selections.clone(); | ||
| let gutters = view.gutters.clone(); | ||
|
|
||
| cx.editor.switch(id, action); | ||
|
|
||
| // match the selection in the previous view | ||
| let (view, doc) = current!(cx.editor); | ||
| view.offset = offset; | ||
| view.jumps = jumps; | ||
| view.docs_access_history = docs_access_history; | ||
| view.last_modified_docs = last_modified_docs; | ||
| view.object_selections = object_selections; | ||
| view.gutters = gutters; |
There was a problem hiding this comment.
How about doing this inside switch, under the split case? You should be able to just view.clone() the current view
There was a problem hiding this comment.
i thought that as well, but the offset was already here, so i just included it haha
thomasskk
pushed a commit
to thomasskk/helix
that referenced
this pull request
Sep 9, 2022
* keep jump/file history when using :split * move history cloning into the switch function Co-authored-by: Robin <robinvandijk@klippa.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i was missing the beheviour from vim