-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
let extend-line respect range direction #3046
Conversation
I think this would be good as a new command but it shouldn't change the existing |
Good point, did the change based on your suggestion. I keep the new command unbind as I couldn't find a good key for it, I think we can bind it in the config for now. |
Co-authored-by: Ivan Tham <pickfire@riseup.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried it out again and doesn't seemed to notice any special differences so I guess should be good. Thanks.
But since this is a breaking change (if user currently specify this themselves), I think we may need to put it in the changelog or so. So I guess will wait for @the-mikedavis to merge this so he knows to write a changelog.
Do we have any procedure to tag like pull request for changelog?
Ah sorry, idk how I missed the ping 😅 I'll note the breaking change in the changelog 👍. I'm not sure there's anything we can do to tag them to make it easier - I look at the compare links which don't have labels. A new label could still be useful though since I do watch the PRs. |
* let extend-line respect range direction * fix extend above logic * keep `x` existing binding * Update book/src/keymap.md Co-authored-by: Ivan Tham <pickfire@riseup.net> Co-authored-by: Ivan Tham <pickfire@riseup.net>
* let extend-line respect range direction * fix extend above logic * keep `x` existing binding * Update book/src/keymap.md Co-authored-by: Ivan Tham <pickfire@riseup.net> Co-authored-by: Ivan Tham <pickfire@riseup.net>
* let extend-line respect range direction * fix extend above logic * keep `x` existing binding * Update book/src/keymap.md Co-authored-by: Ivan Tham <pickfire@riseup.net> Co-authored-by: Ivan Tham <pickfire@riseup.net>
* let extend-line respect range direction * fix extend above logic * keep `x` existing binding * Update book/src/keymap.md Co-authored-by: Ivan Tham <pickfire@riseup.net> Co-authored-by: Ivan Tham <pickfire@riseup.net>
* let extend-line respect range direction * fix extend above logic * keep `x` existing binding * Update book/src/keymap.md Co-authored-by: Ivan Tham <pickfire@riseup.net> Co-authored-by: Ivan Tham <pickfire@riseup.net>
No description provided.