-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
add penumbra+ theme #3398
add penumbra+ theme #3398
Conversation
As to point one I think punctuation should be more clearly visible. Other than that, looks good! |
Yeah I'm enjoying this experiment with deemphasized punctuation, but for the built-in theme we should probably make the conservative choice and do text-colored punctuation.
This is a good point. I like the blue status line for when color modes are disabled, but with them enabled it definitely makes the color modes harder to see. And for a built-in theme we probably want to err on the side of supporting more configurations. |
Another issue I just noticed is that in this PR I accidentally used "white" for variables instead of "sky". I'll fix it later today. |
This looks really good |
2b94abd
to
93baa57
Compare
I think this is ready for review. I reverted the punctuation to be the same color as variables (white) and made the status bar various shades of grey to avoid too much color when combined with the themed status line modes. I think this is the right choice for Helix's default version of this theme, though there's also a commented-out version for those who don't enable the colored modes. The rest of the questions can probably go unanswered. It seems good-enough as is. If people want adjustments for other languages they can always file a PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like scopes for ui.cursorline
are missing. ui.cursorline.primary
is for the primary selection and ui.cursorline.secondary
for all secondaries. Many themes only highlight the primary one. They're not required and are disabled by default (use :set cursorline true
to enable) but it's nice to add them to a shared theme like this for anyone who does want to use cursorline, similar to visible whitespace, rulers and indent-guides. Would you like to add some here?
Yeah, I'd like to make this a "universal" theme as much as possible. I'll add them. |
I just realized that there's no underlining for IDE warnings and errors, which I'd like to have. So I put this PR back into draft status briefly. I'll fix the underlining then mark it as ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice, thank you! 🎨
Could you add a screenshot of this to the themes wiki? https://github.com/helix-editor/helix/wiki/Themes |
Co-authored-by: Vince Mutolo <vince@mutolo.org>
Co-authored-by: Vince Mutolo <vince@mutolo.org>
Co-authored-by: Vince Mutolo <vince@mutolo.org>
From Penumbra's README:
This PR adds a new built-in theme to Helix using the Penumbra+ color scheme. The "+" is for "higher-contrast". Similar versions of this theme for the "balanced" (lower-contrast) and "++" (even higher contrast) variants of Penumbra can be created just be modifying the palette at the bottom of the theme according to the values in Penumbra's README.
This PR is currently in draft status because there are a few questions I wanted to get feedback on.