Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add emacs theme #3410

Merged
merged 6 commits into from
Aug 17, 2022
Merged

Add emacs theme #3410

merged 6 commits into from
Aug 17, 2022

Conversation

Yevgnen
Copy link
Contributor

@Yevgnen Yevgnen commented Aug 13, 2022 •
edited
Loading

This commit adds a complete clone of the Emacs default theme. It is based on the default Emacs settings and the default colors of the emacs-tree-sitter package.

Screenshot:
Screen Shot 2022-08-13 at 16 35 46

Origin:
Screen Shot 2022-08-13 at 23 55 26

@the-mikedavis the-mikedavis self-requested a review August 13, 2022 13:02
@the-mikedavis the-mikedavis added the A-theme Area: Theme and appearence related label Aug 13, 2022
@Yevgnen
Copy link
Contributor Author

Yevgnen commented Aug 16, 2022 •
edited
Loading

Is there a way to customize the underline colors? The Emacs default looks like

Screen Shot 2022-08-16 at 09 07 58

@the-mikedavis
Copy link
Member

Is there a way to customize the underline colors?

Not currently but there's a PR #3015 (comment)

the-mikedavis
the-mikedavis approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@the-mikedavis the-mikedavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks nice, thank you! 🎨

@the-mikedavis the-mikedavis merged commit 956fbab into helix-editor:master Aug 17, 2022
@the-mikedavis
Copy link
Member

Could you add a screenshot to the themes wiki? https://github.com/helix-editor/helix/wiki/Themes

@Yevgnen
Copy link
Contributor Author

Yevgnen commented Aug 17, 2022

@the-mikedavis Done!

AlexanderBrevig pushed a commit to AlexanderBrevig/helix that referenced this pull request Aug 29, 2022
@Yevgnen @AlexanderBrevig
Add emacs theme (helix-editor#3410)
3c346b2
thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
@Yevgnen @thomasskk
Add emacs theme (helix-editor#3410)
052c5d1
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@the-mikedavis the-mikedavis the-mikedavis approved these changes

Assignees
No one assigned
Labels
A-theme Area: Theme and appearence related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yevgnen @the-mikedavis