Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

update colors for papercolor-light #3585

Merged
merged 9 commits into from
Aug 28, 2022

Conversation

uncomfyhalomacro
Copy link
Contributor

@uncomfyhalomacro uncomfyhalomacro commented Aug 28, 2022

image
now looks like this

@uncomfyhalomacro uncomfyhalomacro changed the title fix some colors update colors for papercolor-light Aug 28, 2022
@AlexanderBrevig
Copy link
Contributor

Nice!

@uncomfyhalomacro
Copy link
Contributor Author

ready for merging

Copy link
Contributor

@pickfire pickfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but please update the wiki screenshots if necessary. I wonder if we should have a script to automatically update the wiki based so that contributors don't have to manually do that.

@pickfire pickfire merged commit abb9f13 into helix-editor:master Aug 28, 2022
@uncomfyhalomacro uncomfyhalomacro deleted the paper-color-theme branch August 29, 2022 00:14
@AlexanderBrevig
Copy link
Contributor

Thanks, but please update the wiki screenshots if necessary. I wonder if we should have a script to automatically update the wiki based so that contributors don't have to manually do that.

I definitely think we should do that. Do you know if anyone is working on it?

AlexanderBrevig pushed a commit to AlexanderBrevig/helix that referenced this pull request Aug 29, 2022
* theme: add papercolor light

* fix typo

* add markup highlighting

* theme: added diff colors 

forgot to add it to PaperColor Light

* fix some ui colors

* assign more color for markup headings

* change heading color to bright7
@pickfire
Copy link
Contributor

I definitely think we should do that. Do you know if anyone is working on it?

No, but since you already did improvements on contributor experience on theming, I think you might be interested to give it a try.

AlexanderBrevig pushed a commit to AlexanderBrevig/helix that referenced this pull request Aug 29, 2022
* theme: add papercolor light

* fix typo

* add markup highlighting

* theme: added diff colors 

forgot to add it to PaperColor Light

* fix some ui colors

* assign more color for markup headings

* change heading color to bright7
@AlexanderBrevig
Copy link
Contributor

I will give it a try!

thomasskk pushed a commit to thomasskk/helix that referenced this pull request Sep 9, 2022
* theme: add papercolor light

* fix typo

* add markup highlighting

* theme: added diff colors 

forgot to add it to PaperColor Light

* fix some ui colors

* assign more color for markup headings

* change heading color to bright7
jdrst pushed a commit to jdrst/helix that referenced this pull request Sep 13, 2022
* theme: add papercolor light

* fix typo

* add markup highlighting

* theme: added diff colors 

forgot to add it to PaperColor Light

* fix some ui colors

* assign more color for markup headings

* change heading color to bright7
herkhinah pushed a commit to herkhinah/helix that referenced this pull request Dec 11, 2022
* theme: add papercolor light

* fix typo

* add markup highlighting

* theme: added diff colors 

forgot to add it to PaperColor Light

* fix some ui colors

* assign more color for markup headings

* change heading color to bright7
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants