-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Color palettes #393
Color palettes #393
Conversation
This looks reasonable but it needs a bit of documenting in |
I'll probably migrate over the default |
cc @DrZingo who may be better at reviewing this I don't know how the choices behind the number of palettes. |
Fix the value of purple0. Co-authored-by: DrZingo <DrZingo@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A typo on purple0's color. The naming of 5 bg palette colors is consistent with the naming of gruvbox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks! 🎉 |
This pull request enables theme files to define a palette of named colors, and refer to them in the configuration values that assign colors to UI elements.
Working with a restricted set of colors facilitates theme creation. Additionally, the use of named color identifiers improves the readability of theme files.
The CL includes a theme file that demonstrates this feature by defining a theme using the gruvbox dark color palette.