Shell commands #547
Merged
Shell commands #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is causing the check failure? |
|
I think it's just a github failure, re-running tests now. |
pickfire
reviewed
Aug 4, 2021
pickfire
reviewed
Aug 4, 2021
pickfire
reviewed
Aug 4, 2021
|
I think on POSIX systems we can follow Kakoune's lead: it looks for a |
pickfire
reviewed
Aug 5, 2021
Omnikar
commented
Aug 5, 2021
archseer
reviewed
Aug 5, 2021
archseer
reviewed
Aug 5, 2021
archseer
reviewed
Aug 5, 2021
Closed
Omnikar
commented
Aug 9, 2021
|
Should I do anything with the command's stderr? |
Maybe you can log it? |
|
Instead of unwrapping potential errors, I think I might want to log an error, display a message, and return? |
cessen
requested changes
Aug 26, 2021
`shell` will no longer panic if: * The user-configured shell cannot be found * The shell command does not output UTF-8
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #75.
I've added a config option for
shellwhich would be set likeshell = ["bash", "-c"],but the code does not currently use it because command functions are not able to access config currently. As such, the code is only able to fall back tocmd /Con Windows andsh -cotherwise.Currently, the command's stderr isn't handled.$, which pipes each selection into the command, deleting the selection if the command exits with a nonzero exit status.Shell command completionsconfig.toml.