Change misleading message

[lesleyrs]

Closes #5716

Simple text change copied from nvim so running commands like explorer which opens up file explorer on Windows doesn't explicitly say failed when it actually works.

New:

[archseer]

It might have not exited with exit code 1 though.

[archseer]

I don't see how this could be misleading, the command did fail.

[CptPotato]

This seems to be an issue with explorer. You can also use start on Windows to open a directory or file. The start command also returns a valid exit code (non zero if the path wasn't found). For example :sh start . will open the current directory.

On the other hand, outputting the correct exit code would be helpful in some cases.

[pascalkuthe]

On the other hand, outputting the correct exit code would be helpful in some cases.

I agree, correlating exit code != 0 to failure is the right assumption most of the time so the message should still indicate a failure but actually displaying the statuscode code be helpful. For example to google the problem with whatever program you are calling. Ideally we would display stdout/stderr in a popup aswell but that can be a seperate PR.

Just changing the error message to harcode 1 is actually worse than the current error since the process might not have exited with 1 but 2 instead Command::success just checks status != 0.

I think Shell Command Failed: Status <X> where <X> is the actual status code and not just hard-coded to 1 would be a good change, for the weird edgecases that a process returns a non-zero access code even without failure this seems like an improvement.

Also @CptPotato is right that you should be using start instead of explorer directly (that will also return the right exitcode).

[lesleyrs]

Thanks guys :sh start . gives me Command succeed unlike :sh explorer .!

And yea I was assuming failed command would always return 1 my bad.

I think Shell Command Failed: Status where is the actual status code and not just hard-coded to 1 would be a good change, for the weird edgecases that a process returns a non-zero access code even without failure this seems like an improvement.

I like this, idk how to go about doing it though. I'll close my stuff and leave it for somebody else to make a new pr.

[CptPotato]

If you still want to take this on, it should be quite simple:

output.status is the program's ExitStatus which lets you retrieve the exit code using status.code().

You can display that code using string interpolation in bail!: bail!("blabla {}", exit_code). You only have to handle the case where status.code() returns None (print a message without exit code).