Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add protobuf language support #614

Merged
merged 2 commits into from
Aug 19, 2021
Merged

Conversation

yusdacra
Copy link
Contributor

@yusdacra yusdacra commented Aug 18, 2021

  • Add indents

NOTE: This only supports protobuf 3 syntax.

@yusdacra yusdacra marked this pull request as ready for review August 18, 2021 11:31
@archseer
Copy link
Member

Any reason you chose that grammar instead of https://github.com/mitchellh/tree-sitter-proto ? I think it looks fine otherwise 👍🏻

@yusdacra
Copy link
Contributor Author

Any reason you chose that grammar instead of mitchellh/tree-sitter-proto ? I think it looks fine otherwise 👍🏻

It's basically the same grammar, except the node names are camelCase, and some new grammar is added. I had started working on that so I continued working on it. (may be a good idea to upstream changes there in the future)

@archseer archseer merged commit 2f42b23 into helix-editor:master Aug 19, 2021
@archseer
Copy link
Member

Merged!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants