Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

ocaml support #666

Merged
merged 12 commits into from
Sep 1, 2021
Merged

Conversation

oberblastmeister
Copy link
Contributor

ocaml doesn't support comments to the end of the line. Might need to add a new comment type

@archseer
Copy link
Member

The ocaml grammar provides a locals.scm too, can you include that?

@oberblastmeister
Copy link
Contributor Author

I add locals.scm. Some questions, what is locals.scm for? What is the scope key in languages.toml for?

@oberblastmeister
Copy link
Contributor Author

Also, what is injection regex

@archseer
Copy link
Member

archseer commented Sep 1, 2021

@oberblastmeister
Copy link
Contributor Author

there seems to be an issue when overriding highlights. For example, there seems to be some weirdness in the highlight.scm.
For example if i say all (value_name) is @variable, and I say

(application_expression
  function: (value_path (value_name) @function))`

I would expect the value_name to be overriden and be a function now

except it is not overriden and is not highlighted correctly

@oberblastmeister
Copy link
Contributor Author

thats fixed now, top to bottom worked

@archseer archseer merged commit 5766f5d into helix-editor:master Sep 1, 2021
@starbuckbok

This comment has been minimized.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants