languages: add svelte support

[happysalada]

I'm opening this prospecive PR just to see if I haven't made anything stupid.

I've added the tree-sitter gitmodule
added all the queries file that were in the tree-sitter repository.

I need to update my nix to include the latest PR that downloads the submodules automatically.
I should have time to test this in the next few days.

[kirawi]

(By the way, you're missing the final newline on a few of these files).

[kirawi]

Some of these need to be converted into Helix's scopes: https://docs.helix-editor.com/themes.html

[kirawi]

@archseer Do we want to also add the none scope?

[happysalada]

I've added the newlines, and switched from scm to toml for the indent file.
Regarding the highlights changes, understood. I need to test this to make meaningful changes. I'll update as soon as I could try it.

Thank you for the review!

[kirawi]

Typo punctionation vs. punctuation. I also think the brackets should be punctuation.bracket. Not sure about the rest. I'm not familiar with JS/Svelte, so what do the others do? Depending on what it is, we may be able to include another scope for tag, variable, or keyword.

[happysalada]

Just to give you more context, svelte is a bit like vue, it's a file that contains a mix of html and javascript (or typescript).
Here is how it looks like in a hypothetical inefficient editor
(Note that there are some specificities around { brackets in the html)

[happysalada]

Ok, I just had time to test this, it doesn't work at all.
Svelte is mostly injections, so I'll have a look at fixing that file first.
I'm not sure why the lsp doesn't do anything though. Not sure how to activate/debug.

[archseer]

LSP: Is the binary in your $PATH? Run helix with the -v flag and post the log file.

[happysalada]

binary is in my path

❯ which svelteserver
/Users/raphael/.nix-profile/bin/svelteserver

it seems to run actually, it just doesn't display anything.
Here are the logs
helix.log

[archseer]

binary is in my path

❯ which svelteserver
/Users/raphael/.nix-profile/bin/svelteserver

it seems to run actually, it just doesn't display anything.
Here are the logs
helix.log

It seems to load just fine, are you able to get any completions using ctrl-x in insert mode? Or k over some item to see some documentation etc. I can see the LSP initialization but no interaction with the server.

[happysalada]

I wasn't aware of ctrl-x.
it does work indeed. ctrl-x generates completion. typing some wrong code also gives errors in the editor.
There are just the injections left then. Let me update this in the next few days.

[happysalada]

I've modified the injections to be of the correct format (I think), however those are not working. a svelte file is not being syntax hyghlighted.
I've checked the logs with -v and there are no error or indication that something is going wrong.
Not really sure what to try next.

[archseer]

Can you post a sample .svelte file? I'll give it a go.

[happysalada]

index.svelte.txt

(the normal extension is just .svelte , I added a .txt to enable github upload, feel free to remove the .txt once you've downloaded it)
That should be a fairly standard one. Let me know if I can help in any way.

[archseer]

Fixed in dd0b15e! It worked on css but not for typescript or javascript. I'll let you do a quick test, but other than that I think we're ready for merge.

[happysalada]

The injections didn't work on a style of script attribute for me.
I'm happy to merge though, as having a language server is an infinite improvement.
Plus now that I know where the injections are happening in the code, it gives me a strong incentive to go have a look and figure it out.

Thanks a lot for the help and the time spent on this!

[archseer]

The injections didn't work on a style of script attribute for me.

They don't work for you? <script lang="ts"> was highlighted correctly for me after the patch in master.

[happysalada]

I rebased this branch on master this morning, made sure I had my branch running locally.
I can confirm that I don't get highlights inside script or style tags.
I've turned verbosity on and saw nothing in the logs either.
I'm planning on having a look at the commit you pointed out and how the highlighting works in the next few weeks.

[archseer]

Make sure you cargo clean -p helix-syntax and clear out runtime/grammars/ before building, maybe that will fix it.

[happysalada]

cool, let me check.

[happysalada]

Oh no, just realized that can't be it.
I'm building with the flake directly. So everytime, it compiles from scratch (some of the dependencies are cached of course).

[archseer]

Here's the file you provided for example, after building on this branch from scratch.

[happysalada]

this looks beautiful!

ok let me try to build without the flake then.

[happysalada]

Thanks a lot, local compilation did work, it must be a problem with the flake (or more probable, my usage of it).