Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

CMake support #888

Merged
merged 1 commit into from
Oct 22, 2021
Merged

CMake support #888

merged 1 commit into from
Oct 22, 2021

Conversation

ath3
Copy link
Contributor

@ath3 ath3 commented Oct 21, 2021

This commit adds support for cmake syntax highlighting.

cmake_helix

@ath3
Copy link
Contributor Author

ath3 commented Oct 21, 2021

also the CACHE in the above screenshot is now highlighted for unset too (same with PARENT_SCOPE)

Copy link
Member

@kirawi kirawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

(bracket_argument)
] @string

(variable) @variable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(variable_ref) @none

Was the query taken and modified from original master branch of nvim-treesitter? Seemed different to me here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, its ported from nvim-treesitter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didnt find @none in the documentation, should put variable_ref back in scm, and use some other scope for it?

@archseer archseer merged commit 787ba4f into helix-editor:master Oct 22, 2021
@archseer
Copy link
Member

Thanks! 🎉

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants