Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Launch with defaults upon invalid config/theme #982

Merged
merged 2 commits into from
Nov 6, 2021
Merged

Launch with defaults upon invalid config/theme #982

merged 2 commits into from
Nov 6, 2021

Conversation

Omnikar
Copy link
Contributor

@Omnikar Omnikar commented Nov 4, 2021

Resolves #670.

  • Startup message if there is a problematic config, then launch with default config.
  • Statusline error if trying to switch to an invalid theme, and reject the switch. This results in using the default theme if an invalid theme is set in config.toml.

@Omnikar
Launch with defaults upon invalid config/theme
c077e62 
* Startup message if there is a problematic config
* Statusline error if trying to switch to an invalid theme
@Omnikar Omnikar requested a review from sudormrfbin November 5, 2021 15:55
@archseer archseer merged commit ed23057 into helix-editor:master Nov 6, 2021
@Omnikar Omnikar deleted the use-defaults branch November 6, 2021 16:03
@Omnikar Omnikar mentioned this pull request Nov 6, 2021
Merged
@archseer archseer mentioned this pull request Nov 9, 2021
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sudormrfbin sudormrfbin sudormrfbin approved these changes

@archseer archseer archseer approved these changes

@pickfire pickfire Awaiting requested review from pickfire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Launch with defaults instead of not launching upon invalid config/theme
3 participants
@Omnikar @archseer @sudormrfbin