Add a pydantic model which encapsulates required BMI time meta data #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaraney
requested changes
Apr 23, 2024
bmi_sdk/bmi_sdk/bmi_time.py
Outdated
| # TODO extracted from looking throug the xml files | ||
| # https://docs.unidata.ucar.edu/udunits/current/#Database | ||
| # need to verify this is a complete set... | ||
| valid_units = ["s", "sec", "second", "seconds", |
There was a problem hiding this comment.
I would instead make this into a typing.Literal that can be used here or else where. Then there is also no need for this validator, since pydantic will handle it for you.
|
@hellkite500, just as a heads up, I changed |
taddyb
approved these changes
Apr 24, 2024
hellkite500
commented
Apr 24, 2024
hellkite500
commented
Apr 24, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This model can be used in BMI implementations to store related time components and validate the BMI constraints of these meta data.