Adding option to skip existing releases #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 12, 2021 15:51
Signed-off-by: Eduardo Solis <eduardo.solis@udemy.com>
Signed-off-by: Eduardo Solis <eduardo.solis@udemy.com>
cpanato
reviewed
Mar 14, 2021
There was a problem hiding this comment.
IMHO I think this is ok to have the user can control that part.
LGTM but I would like to hear from the senior maintainer @unguiculus
unguiculus
requested changes
Mar 15, 2021
pkg/releaser/releaser.go
Outdated
|
|
||
| if r.config.SkipExisting { | ||
| existingRelease, _ := r.github.GetRelease(context.TODO(), releaseName) | ||
| if existingRelease != nil && len(existingRelease.Assets) > 0 { |
There was a problem hiding this comment.
I wonder if len(existingRelease.Assets) > 0 makes sense. I'd tend to remove that.
There was a problem hiding this comment.
@unguiculus thank you! removed the check
Signed-off-by: Eduardo Solis <eduardo.solis@udemy.com>
unguiculus
approved these changes
Mar 15, 2021
|
We should probably reference that the |
alokjani
added a commit
to alokjani/chart-releaser
that referenced
this pull request
Sep 26, 2021
Adds reference for using --skip-existing and CR_SKIP_EXISTING
alokjani
added a commit
to alokjani/chart-releaser
that referenced
this pull request
Sep 26, 2021
Adds reference for using --skip-existing and CR_SKIP_EXISTING
|
Updated reference to this in the README in #136 @thesuperzapper @eleduardo thanks for the feature ! |
alokjani
added a commit
to alokjani/chart-releaser
that referenced
this pull request
Sep 26, 2021
Adds reference for using --skip-existing and CR_SKIP_EXISTING Signed-off-by: Alok Jani <alokjani.web@gmail.com>
davidkarlsen
pushed a commit
that referenced
this pull request
Sep 28, 2021
StevenJDH
added a commit
to StevenJDH/helm-charts
that referenced
this pull request
May 6, 2024
* Fixed 422 scenario in release workflow when commits not tied to a release are detected in other charts, helm/chart-releaser#111. * Fixed helm docs rendering of ingress properties showing as json instead of individual values. * Fixed extra whitespace in copy paste example in each template docs. * Fixed missing template docs in test connection pod and notes templates. * Fixed a typo in each template docs. * Fixed job name not using correct template for naming convention. * Fixed incorrect indentation for env field in job template, which was 14 instead of 12. * Removed template.metadata.name field from job because it's not used by k8s, kubernetes/kubernetes#108977.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just ran into bug #65 with the exact same use case that the author of the bug reported. I have a repository for all the charts in my organization what I want is for a CI pipeline to automatically push the charts that have changed. I am trying to keep the CI logic simple and cr is helping me a lot but I do have the issue that not all charts are changing at the same time. What I would like is to be able to tell cr to skip charts that have a name/tag that is already released (a warning can be added).
This seems to be simple, I just added a "skip" flag and if a release already exists it just skips it.
I did not add a test yet since I would like feedback on it before moving forward. Any thoughts on this fix?
thank you for CR!!