Add note about GHE upload URL bug #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnowy
reviewed
Apr 25, 2020
README.md
Outdated
Comment on lines
175
to
176
| https://example.com/api/v3/ | ||
| https://example.com/api/uploads/ |
There was a problem hiding this comment.
Maybe better use usual links for GitHub enterprise:
Suggested change
| https://example.com/api/v3/ | |
| https://example.com/api/uploads/ | |
| https://github.yourcompany.com/api/v3/ | |
| https://github.yourcompany.com/api/uploads/ |
There was a problem hiding this comment.
@pnowy I didn't apply this exactly as written (as I'd argue that there is very little guarantee about how companies name their GHE domains) but I did make a minor tweak to hopefully make the general point a bit more obvious.
Signed-off-by: Sean P. Kane <skane@newrelic.com>
Signed-off-by: Sean P. Kane <skane@newrelic.com>
spkane
force-pushed
the
spkane/ghe-upload-bug
branch
from
6dcbd86 to
8bfda12
Compare
|
@scottrigby Is there anything else needed to get this merged? |
unguiculus
approved these changes
Apr 26, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes about using this tool with Github Enterprise and a known gotcha as noted in #57