This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/rabbitmq] Normalize ports under service #9444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com>
helm-bot
added
Contribution Allowed
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carrodher, javsalgar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Guys, would it be possible to write upgrade documentation for the next breaking changes? |
|
Thanks for pointing it, I created a task to work on it |
davidkarlsen
pushed a commit
to davidkarlsen/charts
that referenced
this pull request
Dec 2, 2018
Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com>
yuchaoran2011
pushed a commit
to yuchaoran2011/charts
that referenced
this pull request
Dec 11, 2018
Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com> Signed-off-by: Chaoran Yu <yuchaoran2011@gmail.com>
wgiddens
pushed a commit
to wgiddens/charts
that referenced
this pull request
Jan 18, 2019
Signed-off-by: Javier J. Salmeron Garcia <jsalmeron@bitnami.com>
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Javier J. Salmeron Garcia jsalmeron@bitnami.com
What this PR does / why we need it:
This chart normalizes bitnami charts by setting ports under service.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]