Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

remove io/ioutil for advanced golang #11514

Closed
wants to merge 1 commit into from
Closed

remove io/ioutil for advanced golang #11514

wants to merge 1 commit into from

Conversation

yanggangtony
Copy link
Contributor

Signed-off-by: yanggang gang.yang@daocloud.io

What this PR does / why we need it:
We should clean all io/util package according the url: https://go.dev/doc/go1.16#ioutil
/kind cleanup

Signed-off-by: yanggang <gang.yang@daocloud.io>
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 6, 2022
@yanggangtony
Copy link
Contributor Author

/cc @sabre1041 @cndoit18
PTAL

Copy link
Contributor

@phil9909 phil9909 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yxxhero yxxhero modified the milestones: 3.11.0, 3.10.3 Nov 8, 2022
@yanggangtony
Copy link
Contributor Author

@yxxhero
hi , i look the tag you add..
so ,this pr will be merged in 3.11.0 and 3.11.3??

@yxxhero
Copy link
Member

yxxhero commented Nov 11, 2022

@yanggangtony this PR will be merged in 3.10.3. means the next patch release.

@yanggangtony
Copy link
Contributor Author

this PR will be merged in 3.10.3. means the next patch release.
@yxxhero
thanks for reply
got it

@hickeyma hickeyma modified the milestones: 3.10.3, 3.11.0 Dec 14, 2022
@mattfarina mattfarina modified the milestones: 3.11.0, 3.12.0 Jan 18, 2023
@joejulian joejulian modified the milestones: 3.12.0, 3.13.0 May 5, 2023
@yanggangtony
Copy link
Contributor Author

/close

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants