Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

issue/106 default null #108

Merged
merged 1 commit into from
Nov 20, 2022
Merged

issue/106 default null #108

merged 1 commit into from
Nov 20, 2022

Conversation

FoseFx
Copy link
Member

@FoseFx FoseFx commented Nov 19, 2022 •
edited
Loading

Closes #106

@FoseFx FoseFx marked this pull request as ready for review November 20, 2022 11:39
@FoseFx FoseFx requested a review from a team as a code owner November 20, 2022 11:39
@felixevers
Copy link
Member

Still depending on #105. Please merge to avoid code reviewing some changes twice.

@FoseFx FoseFx force-pushed the issue/106_default-null branch from c947bc7 to ae7dbdb Compare November 20, 2022 11:43
@FoseFx
Copy link
Member Author

FoseFx commented Nov 20, 2022

fastest rebase in the west

felixevers
felixevers approved these changes Nov 20, 2022
View reviewed changes
Copy link
Member

@felixevers felixevers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could add some more default values from a semantic perspective.
But the endpoints will handle it in the right way.

@FoseFx FoseFx merged commit 1e13ef3 into main Nov 20, 2022
@FoseFx FoseFx deleted the issue/106_default-null branch November 20, 2022 11:52
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@felixevers felixevers felixevers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gorm:"default:NULL" all models
2 participants
@FoseFx @felixevers