Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bug fixes and enhancements #13

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

syskill
Copy link

@syskill syskill commented Jan 26, 2022

These commits fix issues #11 and #12, and also add support for the ECS metadata service.

This can be set in the config file or on the command line, e.g.
`--setopt=aws.container_credentials_path=$AWS_CONTAINER_CREDENTIALS_RELATIVE_URI`
The container metadata server cannot be used if the default metadata
server http://169.254.169.254 is specified in the config file.
The use of `--setopt=...` described in commit c417342 unfortunately has
no effect.
The PLUGINS doc doesn't mention this possibility, but the pattern in
other Yum plugins is clear.
The latest Python packages for Amazon Linux 2 incorporate a fix for
CVE-2022-0391, which makes the `urlsplit` function remove newlines and
tabs from the URL.
Copy link

@RulerOf RulerOf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, these changes look good to me and are functioning well in my environment.

I recommend merging.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants