-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Bug fixes and enhancements #13
Open
syskill
wants to merge
9
commits into
henrysher:master
Choose a base branch
from
syskill:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be set in the config file or on the command line, e.g. `--setopt=aws.container_credentials_path=$AWS_CONTAINER_CREDENTIALS_RELATIVE_URI`
The container metadata server cannot be used if the default metadata server http://169.254.169.254 is specified in the config file.
The use of `--setopt=...` described in commit c417342 unfortunately has no effect.
The PLUGINS doc doesn't mention this possibility, but the pattern in other Yum plugins is clear.
The latest Python packages for Amazon Linux 2 incorporate a fix for CVE-2022-0391, which makes the `urlsplit` function remove newlines and tabs from the URL.
RulerOf
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, these changes look good to me and are functioning well in my environment.
I recommend merging.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits fix issues #11 and #12, and also add support for the ECS metadata service.