Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Replacing cubied with run-cvmfs.sh (issue #20) #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kreczko
Copy link
Collaborator

@kreczko kreczko commented Sep 6, 2017

PR regarding issue #20

  • removed all traces of cubied
  • modified run-cvmfs.sh to execute the CMD
  • changed ENTRYPOINT cubiedrun-cvmfs.sh

Tested with

docker build -t hepsw/cvmfs-base .
docker run --privileged -ti hepsw/cvmfs-base ls -l /cvmfs/sft.cern.ch/lcg/

@sbinet
Copy link
Contributor

sbinet commented Sep 6, 2017

ah. well, cubied is still needed (so it can properly act as a mini PID 1 process, reaping zombies and such).

wouldn't it work with adding another shell script (so it doesn't confuse gitlab-runner) that runs cubied ?

@kreczko
Copy link
Collaborator Author

kreczko commented Sep 6, 2017

At the moment everything you run in the container is encapsulated in cubied, e.g.

#!/usr/bin/cubied

echo "::: cvmfs-config..."
cvmfs_config setup || exit 1

echo "::: mounting FUSE..."
mount -a
echo "::: mounting FUSE... [done]"

exec "$@"

This includes the gitlab-runner shell check:
https://gitlab.com/gitlab-org/gitlab-ci-multi-runner/blob/master/shells/bash.go

Unless the gitlab-runner is able to resolve cubied, I don't think there is a better workaround.

That said, our CI container (cvmfs-basecvmfs-lzlz-builder) is independent of this PR, so there is no need to merge until we find a better solution.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants