Add proxy support for the update Jenkins task #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnonnenmacher
suggested changes
Apr 11, 2019
There was a problem hiding this comment.
Thanks a lot!
Please improve the commit message title a bit, something like "Add proxy support for the update Jenkins task" and mention in the text that authentication is not supported, and that this can be configured either in the server configuration or on the command line.
plugin/src/main/groovy/com/here/gradle/plugins/jobdsl/RestJobManagement.groovy
Show resolved
Hide resolved
Proxy settings can be configured either in the server configuration or via the command line. Authentication is not supported for now. Signed-off-by: Renzo Crisóstomo <renzo.crisostomomedina@here.com>
UnsafePointer
changed the title
|
@mnonnenmacher thanks for the review, I attended to all comments. |
mnonnenmacher
approved these changes
Apr 11, 2019
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our Jenkins instance can only be reached through an HTTP proxy, this PR adds proxy support for the update Jenkins task, either in the server configuration or the command line. Authentication is not supported.