Make Groovy Seed Job more resilient to errors when creating/updating jobs/views #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnonnenmacher
suggested changes
Jun 12, 2018
| } | ||
| } catch (Exception ignored) { | ||
| if (view) { | ||
| println "Could not update ${fullName}" |
There was a problem hiding this comment.
It would be nice to print at least the Exception message:
`println "Could not update ${fullName}: ${e.message}"
Same for the messages below.
There was a problem hiding this comment.
Yeah, you're right. Will update this.
…jobs or views This might be a edge-case situation but in the case of #79, when there's a bug in the seed job groovy script that produces an error before the seed job being able to update itself a manual intervention is required. With this change, errors while processing the xml would be ignored and the seed job would be able to update itself if none of the xml errors are related to it.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be a edge-case situation but in the case of #79, when there's a bug in the seed job groovy script that produces an error before the seed job being able to update itself a manual intervention is required. With this change, errors while processing the xml would be ignored and the seed job would be able to update itself if none of the xml errors are related to it.