Sys: Use GitHub releases as kernel source #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkroening
force-pushed
the
sys-github-release
branch
from
200765e to
2f50a65
Compare
This removes the dependency on cargo-download.
mkroening
force-pushed
the
sys-github-release
branch
from
2f50a65 to
3434197
Compare
stlankes
approved these changes
Mar 11, 2022
|
bors r+ |
|
Build succeeded: |
mkroening
added a commit
to hermit-os/loader
that referenced
this pull request
Mar 27, 2022
mkroening
added a commit
to mkroening/libhermit-rs
that referenced
this pull request
Mar 27, 2022
This was referenced Mar 27, 2022
bors bot
added a commit
to hermit-os/loader
that referenced
this pull request
Mar 27, 2022
63: Remove cargo-download r=mkroening a=mkroening See hermit-os/hermit-rs#243 Co-authored-by: Martin Kröning <mkroening@posteo.net>
bors bot
added a commit
to hermit-os/kernel
that referenced
this pull request
Mar 27, 2022
407: runtime_glue: Remove __rg_oom r=mkroening a=mkroening 408: Update toolchain to 2022-03-27 r=mkroening a=mkroening This is the first nightly to not include the hermitkernel targets. 409: Remove cargo-download r=mkroening a=mkroening See hermit-os/hermit-rs#243 Co-authored-by: Martin Kröning <mkroening@posteo.net>
bors bot
added a commit
to hermit-os/kernel
that referenced
this pull request
Mar 27, 2022
408: Update toolchain to 2022-03-27 r=mkroening a=mkroening This is the first nightly to not include the hermitkernel targets. 409: Remove cargo-download r=mkroening a=mkroening See hermit-os/hermit-rs#243 Co-authored-by: Martin Kröning <mkroening@posteo.net>
bors bot
added a commit
to hermit-os/kernel
that referenced
this pull request
Mar 27, 2022
407: runtime_glue: Remove __rg_oom r=mkroening a=mkroening 409: Remove cargo-download r=mkroening a=mkroening See hermit-os/hermit-rs#243 Co-authored-by: Martin Kröning <mkroening@posteo.net>
bors bot
added a commit
to hermit-os/kernel
that referenced
this pull request
Mar 27, 2022
409: Remove cargo-download r=mkroening a=mkroening See hermit-os/hermit-rs#243 416: Don't modify the loader's Makefile r=mkroening a=mkroening Support for windows has been added to the Makefile upstream. Co-authored-by: Martin Kröning <mkroening@posteo.net>
bors bot
added a commit
to hermit-os/kernel
that referenced
this pull request
Mar 27, 2022
409: Remove cargo-download r=mkroening a=mkroening See hermit-os/hermit-rs#243 Co-authored-by: Martin Kröning <mkroening@posteo.net>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #193.
Note that this results in using a hardcoded kernel version instead of using the latest one. This is similar to us explicitly updating the submodule instead of using the latest git version. While we could use the latest version, I am not sure if it makes sense. What do you think? 🤔