feat(uhyve): use absolute paths #1529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n0toose
commented
Dec 25, 2024
There was a problem hiding this comment.
The change works well enough using the latest version of Uhyve using both /root/foo.txt and /root/guest_directory/foo.txt with the file mappings:
--file-mapping foo.txt:/root/guest_directory/foo.txt--file-mapping ./:/root/guest_directory/--file-mapping .////:/root/guest_directory--file-mapping .:/root/guest_directory
Some edge cases exist, particularly --file-mapping ./:/root -- however, this problem existed before when entering "" instead of /root (the prefix), as we do now. I believe that my change follows the principle of "perfect is the enemy of good" and that it's better than it was before.
Nevertheless, I left two comments in places that could use a second pair of eyes.
| // Unlike src/fs/fuse.rs, we skip the first element here so as to not prepend / before /root | ||
| let path: String = components_with_prefix | ||
| .flat_map(|component| ["/", component]) | ||
| .skip(1) |
There was a problem hiding this comment.
Not sure about this skip.
Instead of handling the null terminators ourselves, we relied on the FUSE implementation to store a "prefix" in UhyveDirectory and begun using CStrings instead. This is based on the previous work of Çağatay Yiğit Şahin.
n0toose
force-pushed
the
uhyve-use-absolute-paths
branch
from
2b33fd0 to
818df0d
Compare
mkroening
approved these changes
Jan 3, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
n0toose
added a commit
to n0toose/uhyve
that referenced
this pull request
Jan 5, 2025
Ported from hermit-os#816, fixes a regression introduced by hermit-os/kernel#1529, which modified the Hermit kernel so that it uses absolute paths instead of relative ones.
github-merge-queue bot
pushed a commit
to hermit-os/uhyve
that referenced
this pull request
Jan 9, 2025
Ported from #816, fixes a regression introduced by hermit-os/kernel#1529, which modified the Hermit kernel so that it uses absolute paths instead of relative ones.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of handling the null terminators ourselves, we relied on the FUSE implementation to store a “prefix” in
UhyveDirectoryand began usingCStrings instead.This is based on the previous work of Çağatay Yiğit Şahin (58da426).