Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Rework printing #101

Merged
merged 1 commit into from
May 24, 2022
Merged

Rework printing #101

merged 1 commit into from
May 24, 2022

Conversation

mkroening
Copy link
Member

This reworks printing.

  1. Casting char to u8 is incorrect for multi-byte characters. The new implementation now correctly prints emojis. 💖
  2. I added _print for not having to handle the Console inside the macros.
  3. I aligned the macros with their updated std counterparts.

@mkroening mkroening self-assigned this May 24, 2022
@mkroening
Copy link
Member Author

bors r+

@bors
Copy link
Contributor

bors bot commented May 24, 2022

Build succeeded:

@bors bors bot merged commit 7f3e8ce into hermit-os:master May 24, 2022
@mkroening mkroening deleted the print-rework branch May 24, 2022 21:59
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@mkroening mkroening

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mkroening