Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: put memory and env vars into FDT #758

Merged
merged 5 commits into from
Sep 25, 2024
Merged

feat: put memory and env vars into FDT #758

merged 5 commits into from
Sep 25, 2024

Conversation

mkroening
Copy link
Member

@mkroening mkroening commented Sep 20, 2024

Depends on Kernel PR: hermit-os/kernel#1394
CI should be fixed by hermit-os/kernel#1396.

@jounathaen
Copy link
Member

LGTM. I think you probably have to update the raw images as well.

@mkroening mkroening assigned mkroening and unassigned jounathaen Sep 24, 2024
@mkroening mkroening changed the title feat: put env vars into FDT bootargs feat: put memory and env vars into FDT Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 23 lines in your changes missing coverage. Please review.

Project coverage is 67.82%. Comparing base (5dea30b) to head (53c4608).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/fdt.rs 74.11% 22 Missing ⚠️
src/bin/uhyve.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
+ Coverage   67.24%   67.82%   +0.57%     
==========================================
  Files          18       19       +1     
  Lines        2345     2455     +110     
==========================================
+ Hits         1577     1665      +88     
- Misses        768      790      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jounathaen
Copy link
Member

Looks alright, but here again you could do me a favor and just add some doc comments to src/fdt.rs

@mkroening
Copy link
Member Author

some doc comments

Happy? ^^

@jounathaen
Copy link
Member

❤️ ❤️ ❤️ ❤️

Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
Signed-off-by: Martin Kröning <martin.kroening@eonerc.rwth-aachen.de>
@mkroening mkroening added this pull request to the merge queue Sep 25, 2024
Merged via the queue into main with commit 6e51811 Sep 25, 2024
10 checks passed
@mkroening mkroening deleted the fdt branch September 25, 2024 16:49
@mkroening mkroening mentioned this pull request Nov 29, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants