Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor: split isolation.rs into files #814

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

n0toose
Copy link
Member

@n0toose n0toose commented Nov 29, 2024

This is a form of preparation for the introduction of additional security-related measures, which may be best to implement in separate files.

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.55%. Comparing base (cb1371f) to head (c9535e6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #814   +/-   ##
=======================================
  Coverage   71.55%   71.55%           
=======================================
  Files          21       22    +1     
  Lines        3041     3041           
=======================================
  Hits         2176     2176           
  Misses        865      865           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jounathaen
Copy link
Member

👍

@jounathaen jounathaen added this pull request to the merge queue Dec 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Dec 1, 2024
This is a form of preparation for the introduction of additional
security-related measures, which may be best to implement in separate
files.
@n0toose n0toose force-pushed the sandbox-refactor-isolation-source branch from 4c76b68 to c9535e6 Compare December 1, 2024 18:35
@n0toose
Copy link
Member Author

n0toose commented Dec 1, 2024

not sure if i got the write access on purpose - but given you attempted to merge this and that the conflict was only really about removing tempdir's dependencies from filemap.rs (and because the tests pass), i'm assuming that it's OK if i merge this myself either way

@n0toose n0toose added this pull request to the merge queue Dec 1, 2024
Merged via the queue into hermit-os:main with commit ad51f75 Dec 1, 2024
11 checks passed
@n0toose n0toose deleted the sandbox-refactor-isolation-source branch December 1, 2024 19:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants