fix ISession.CreateTime #173
Conversation
| @@ -41,6 +41,7 @@ public async Task ShouldAuthenticateCustomId() | |||
| Assert.NotNull(session.UserId); | |||
| Assert.NotNull(session.Username); | |||
| Assert.False(session.IsExpired); | |||
| Assert.Equal(DateTimeOffset.UtcNow.ToUnixTimeSeconds(), session.CreateTime); | |||
There was a problem hiding this comment.
This may fail if the auth takes 1s to return, shouldn't happen but I wonder if there's a better way of testing time related assertions?
There was a problem hiding this comment.
@sesposito session.CreateTime is actually not returned by the JWT from the server (unless you understand differently?); it's actually set on the session on the client after the server returns. So the chance of the values being unequal would be approx. 1 in a billion on most devs CPUs. That being said, could take a "before authentication" timestamp and "after authentication" timestamp and just ensure that the session.CreateTime falls within the range?
|
Luke Gehorsam seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
No description provided.