-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: make heroku data env var override redis host too. #3239
base: main
Are you sure you want to change the base?
Conversation
7aeadb9
to
6888527
Compare
@xiaolin-ninja do you have a work item for this change? These could be considered breaking changes and I'd like to get some more context on why they are necessary. |
Yes! Sorry I added the work item and the Slack discussion about it. It was an oversight to not add |
Co-authored-by: Justin Downing <jdowning@heroku.com>
HEROKU_DATA_HOST
sets custom Data-API endpoint for Postgres and Kafka, but not Redis.This makes it so that this env var sets Redis as well, and removes the
HEROKU_POSTGRES_HOST
andHEROKU_KAFKA_HOST
endpoints to eliminate the situation where the CLI talks to different hosts for different services.https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00002AjJ4mYAF/view
Discussion here: https://salesforce-internal.slack.com/archives/C04N31RE732/p1741012577493589?thread_ts=1741010679.617519&cid=C04N31RE732
Testing:
HEROKU_DATA_HOST
changes the host for Redis, Kafka, & Postgres:HEROKU_REDIS_HOST
doesn't affect anything:HEROKU_POSTGRES_HOST
doesn't affect anything: