Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Can not output extraKey I passed in when using logging/zap #61

Closed
ponecrazy opened this issue Dec 13, 2024 · 2 comments · Fixed by #62
Closed

Can not output extraKey I passed in when using logging/zap #61

ponecrazy opened this issue Dec 13, 2024 · 2 comments · Fixed by #62

Comments

@ponecrazy
Copy link

ponecrazy commented Dec 13, 2024 •
edited
Loading

Describe the bug

When using logging/zap with otel, if the span's IsValid() is false, the extraKey I passed in cannot be output in the log

Screenshots

image

github.com/hertz-contrib/obs-opentelemetry/logging/zap/logger.go: 59

Version
github.com/hertz-contrib/obs-opentelemetry/logging/zap v0.0.0-20240705015228-9abdf96254a2
github.com/hertz-contrib/obs-opentelemetry/tracing v0.4.1
@ponecrazy ponecrazy changed the title Can not output extraKey when using logging/zap Can not output extraKey I passed in when using logging/zap Dec 13, 2024
@GuangmingLuo
Copy link
Contributor

@rogerogers please take a look

@rogerogers rogerogers mentioned this issue Dec 17, 2024
Merged
@rogerogers
Copy link
Collaborator

Thank you for the feedback. Update and try again.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix[zap]: extraKey rogerogers/hertz-obs-opentelemetry
3 participants
@GuangmingLuo @ponecrazy @rogerogers