Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat(tags/img): support quotes in img title and alt #5112

Merged
merged 1 commit into from
Nov 25, 2022
Merged

feat(tags/img): support quotes in img title and alt #5112

merged 1 commit into from
Nov 25, 2022

Conversation

stevenjoezhang
Copy link
Member

What does it do?

Issue resolved: #4715

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@github-actions
Copy link

github-actions bot commented Nov 21, 2022 •
edited
Loading

Publish flamegraph to https://d307876bcbb86d14e7f435d9aadbbc0bf7daa15f-18-hexo.surge.sh/flamegraph.html

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 98.743% when pulling d7d0fe6 on regex into 807ddd8 on master.

@stevenjoezhang stevenjoezhang requested a review from a team November 25, 2022 09:00
yoshinorin
yoshinorin approved these changes Nov 25, 2022
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stevenjoezhang stevenjoezhang merged commit 58a8f8c into master Nov 25, 2022
@stevenjoezhang stevenjoezhang deleted the regex branch November 25, 2022 12:27
@stevenjoezhang stevenjoezhang mentioned this pull request Nov 25, 2022
Closed
5 tasks
@yoshinorin yoshinorin added this to the 7.0.0 milestone Nov 25, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

How to contain a single quote or a double quote in images' title and alt?
3 participants
@stevenjoezhang @coveralls @yoshinorin