Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add url_for and full_url_for tag plugins #5198

Merged
merged 2 commits into from
Jun 3, 2023

Conversation

D-Sketon
Copy link
Member

@D-Sketon D-Sketon commented Apr 28, 2023

What does it do?

fix #4749

Screenshots

Pull request tasks

  • Add test cases for the changes.
  • Passed the CI test.

@github-actions
Copy link

How to test

git clone -b v7.0.0_3 https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test

@yoshinorin
Copy link
Member

@D-Sketon
Sorry, I made mistake...
#5178 does not satisfy CI. We need fix TS2544 first.

@D-Sketon
Copy link
Member Author

@D-Sketon Sorry, I made mistake... #5178 does not satisfy CI. We need fix TS2544 first.

should #5202 be merged?

@yoshinorin
Copy link
Member

@D-Sketon
Thank you :)
I didn't notice that. Just now I merged #5202

Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Would you please submit a documentation DraftPR to https://github.com/hexojs/site after merge this?

@D-Sketon
Copy link
Member Author

D-Sketon commented Jun 3, 2023

LGTM 🚀

Would you please submit a documentation DraftPR to https://github.com/hexojs/site after merge this?

I have submited a PR hexojs/site#2022 😀

@yoshinorin yoshinorin merged commit c9ad8c6 into hexojs:v7.0.0 Jun 3, 2023
@stevenjoezhang stevenjoezhang linked an issue Jul 27, 2023 that may be closed by this pull request
2 tasks
@stevenjoezhang stevenjoezhang mentioned this pull request Jul 27, 2023
2 tasks
@D-Sketon D-Sketon deleted the v7.0.0_3 branch October 6, 2023 08:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

url_for tag plugin
2 participants